Revive unreachable taint #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masayuki Ishii <[email protected]>
morimoto-cybozu
approved these changes
Dec 10, 2024
|
It would be good to update CHANGELOG. YZ775 is bumping version in #779. Would you please suspend merge until the release of 1.30.2? |
|
@masa213f @morimoto-cybozu |
Sory, I missed this comment. I'll update CHANGELOG from now and release this update. |
masa213f
added a commit
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Masayuki Ishii <[email protected]>
masa213f
added a commit
that referenced
this pull request
Dec 12, 2024
Signed-off-by: Masayuki Ishii <[email protected]>
masa213f
added a commit
that referenced
this pull request
Dec 13, 2024
Revive unreachable taint (backport of #780)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds (revives) the following taint.
cke.cybozu.com/state: unreachable(NoSchedule)This taint was removed in #710. However, since
node.kubernetes.io/unreachabletaint alone was not sufficient for our operations, so I'll revives the taint.