Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sibling fix #834

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Conversation

shresthabijay
Copy link
Contributor

fixes #816

use isEditing to track change of focus in Editable
@shresthabijay
Copy link
Contributor Author

@raineorshine The issue was the oldValue was not being updated after the thoughtsRanked being accessed from props was updated. Since thoughtChangeHandler checks if the oldValue has any associated thought using getThought, it prevented dispatching exisitingThoughtChange. I made the necessary changes to fix it. Apart from that I have made some changes to the ContentEditable to use isEditing to track focus state instead of using document.activeElement which was not reliable between re-renders. Please test the changes. Thanks!

@raineorshine
Copy link
Contributor

Thanks for the quick turnaround! Works great.

@raineorshine raineorshine merged commit 0955b7c into cybersemics:dev Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit after merge siblings broken
2 participants