Test: existingThoughtChange #815
Conversation
| expect(getThoughts(stateNew, [ROOT_TOKEN])) | ||
| .toMatchObject([{ value: 'b', rank: 1 }, { value: 'aa', rank: 0 }]) | ||
|
|
||
| expect(stateNew.cursor) |
There was a problem hiding this comment.
Cursor does not update upon editing the active thought.
There was a problem hiding this comment.
@raineorshine The state.cursor in this case returns the original path, before edit, i.e [ { value: 'a', rank: 0 } ]
There was a problem hiding this comment.
Good catch. It appears that existingThoughtChange does not update the cursor at all. This will be fixed separately.
| - ab`) | ||
|
|
||
| // ab should exist in both contexts a and b | ||
| expect(getContexts(stateNew, 'ab')) |
There was a problem hiding this comment.
getContexts return the context b with rank: 0.
There was a problem hiding this comment.
@raineorshine
getContexts in this case returns the following:
[ { context: [ 'a' ], id: '266e7ff0-aa5c-4927-a8a2-bcc2591b8e85', rank: 0 }, { context: [ 'b' ], rank: 0, id: '0783bcd8-c2b8-4e48-9487-a530b3b44be2' } ]
Notice that the b should have rank: 1, but instead it returns rank: 0, which is not desirable.
There was a problem hiding this comment.
This is correct actually. Since getContexts returns ThoughtContexts not Child nodes, rank represents the rank of the value within each context. i.e. in Context ['a'] the thought ab has rank 0, and in Context ['b'] the thought ab also has rank 0. Ranks are only unique within the same Context.
|
It looks like the tests are failing. Can you provide an update on this? Is this still in progress? I couldn't tell whether your comments were notes to yourself, or questions, or something else. Thanks! |
|
@raineorshine The comments are notes/reasons for why the tests are failing. Just added more details. The methods does not seem to return the desired values. Let me know how should I proceed. Thanks! |
Fixes #803