Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: existingThoughtMove #810

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Test: existingThoughtMove #810

merged 2 commits into from
Jul 23, 2020

Conversation

aqkhan
Copy link
Contributor

@aqkhan aqkhan commented Jul 22, 2020

Fixes #804

raineorshine
raineorshine approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@raineorshine raineorshine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I'm looking for. Thank you!

src/reducers/__tests__/existingThoughtMove.js Outdated
rank: -1,
}])

// contexts of both the descendants of b should remain unchanged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this tests that the contexts of the descendants have changed (correctly), rather than remain unchanged.

src/reducers/__tests__/existingThoughtMove.js Outdated
rank: 1,
}])

// context for both the descendants of b should remain unchanged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@raineorshine raineorshine reopened this Jul 23, 2020
@raineorshine raineorshine merged commit 9a46954 into cybersemics:dev Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raineorshine raineorshine raineorshine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test: existingThoughtMove
2 participants
@aqkhan @raineorshine