Strip tags on clearThought

[shresthabijay]

fixes #743

[shresthabijay]

@raineorshine We cannot render html within placeholder so it would make sense to just strip away all the tags. What do you think ?

[raineorshine]

Yes, that's correct. It won't have any non-formatting tags anyway since they have already been stripped out during editing.

[raineorshine]

We currently have two other regex definitions that strip tags/html. Could you assess whether they can be combined into a single regex, and if so, have them all (including clearThought) reference that regex from constants? Thanks!

• https://github.com/cybersemics/em/blob/dev/src/constants.ts#L194
• https://github.com/cybersemics/em/blob/dev/src/util/hashThought.ts#L8

[shresthabijay]

@raineorshine The REGEXP_HTML in constants /<\/?[a-z][\s\S]*>/i doesn't do strict tag checks. <p>test> as a whole will pass the regex test. Is this intentional ?

[raineorshine]

REGEXP_HTML is currently used to detect HTML, not replace tags. I'm not sure what you mean by "strict tag checks."

You should be able to see exactly where each of the HTML-related regular expressions are being used, and determine if any of them can be combined based on their use.

[raineorshine]

@shresthabijay Any updates on this?

[shresthabijay]

@raineorshine The REGEXP_HTML is quite different from the regex used for tags in hashThought. But the tags regex used in clear thought is same as used in hashThought, so I exported it as a separate constant.

[raineorshine]

Perfect, thanks!