Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undo redo tests part 1 #2665

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

mstrofbass
Copy link
Collaborator

@mstrofbass mstrofbass commented Dec 2, 2024

This fixes one of the two skipped undo/redo tests by awaiting the initialize call and removing the use of the fake timers.

Key insight here is that since the tests that use initialize were originally skipped, the code has changed in such a way that we can await the initialize call without problem.

The second test is slightly more difficult to fix so wanting to get this merged instead of waiting.

Solves part of #2145

@mstrofbass mstrofbass marked this pull request as ready for review December 2, 2024 04:23
@raineorshine raineorshine merged commit a957a06 into cybersemics:main Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants