Fix/fade in new thought #2589
Fix/fade in new thought #2589
Conversation
There was a problem hiding this comment.
Thanks for the PR!
@zukilover / @yangchristina / @raineorshine, please let me know whether you would rather proceed with this PR or with #2601 which resolved the merge conflicts but may have made other changes in doing so.
It would generally be nicer to wait until A (#2581) is merged before submitting B (#2589) for review when B depends on changes in A, but I will review this one because B might have a separate issue that will take time to resolve (#2581 (comment)).
1. Disappearing thoughts
Thoughts are unexpectedly disappearing from the end of the list when inserting new thoughts before them
Steps to reproduce
- foo
- bar
- baz
- Set the cursor on
foo newThoughtseveral times
Current Behavior
The bar and baz thoughts disappear:
Screen.Recording.2024-11-18.at.11.08.05.PM.mov
Expected Behavior
The thoughts should not disappear. Demo from the main branch:
Screen.Recording.2024-11-18.at.11.06.24.PM.mov
|
|
||
| // Speed up the tree-node's transition by 50% on New (Sub)Thought only. | ||
| const isNewThought = value === '' | ||
| const layoutDuration = isNewThought ? `layoutNodeAnimationFastDuration` : `layoutNodeAnimationDuration` |
There was a problem hiding this comment.
This duration does not appear to have the intended effect (or any effect?). Since the duration is so short, I updated layoutNodeAnimationDuration to 5000 ms in the durations config to test it locally. Doing so doesn't seem to have lengthened the duration of any animations for a new subthought:
Screen.Recording.2024-11-18.at.10.53.22.PM.mov
I also increased the value of layoutNodeAnimationDuration with the same unchanged results.
|
Marking as draft until #2581 is merged. Stay tuned. |
Fixes #1790
This PR is branched off of #2581 because it depends on the new
CSSTransitionfortree-nodeelement.Added new property
valuefor theTreeThoughtto distinguish new thoughts.End result:
screencast-localhost_3000-2024_11_15-14_58_10.mp4