Side Drawer

[shresthabijay]

Fixes #180

[shresthabijay]

added hamburger menu for both mobile and desktop view and added .npmrc file for setting up bit registry.

[raineorshine]

I recommend rebasing on dev to avoid additional merge conflict headaches.

[shresthabijay]

I recommend rebasing on dev to avoid additional merge conflict headaches.

Will do that

[raineorshine]

I'm very happy with what I see! The functionality is nearly perfect, and you accounted for the many, spread out changes needed to sync with state, local, and remote.

The suggestions are a combination of code quality recommendations, small bugs, and the use of mutations in existingThoughtChange.

Please run the linter manually (npm run lint) as the automated check is not failing properly.

The only other bug not listed here is the neglect of existingThoughtMove. When a thought is moved (either through drag-and-drop or the keyboard command Ctrl + Shift + Up/Down), it breaks recently edited functionality. The links should be updated as with edit.

[shresthabijay]

I'm very happy with what I see! The functionality is nearly perfect, and you accounted for the many, spread out changes needed to sync with state, local, and remote.

The suggestions are a combination of code quality recommendations, small bugs, and the use of mutations in existingThoughtChange.

Please run the linter manually (npm run lint) as the automated check is not failing properly.

The only other bug not listed here is the neglect of existingThoughtMove. When a thought is moved (either through drag-and-drop or the keyboard command Ctrl + Shift + Up/Down), it breaks recently edited functionality. The links should be updated as with edit.

[shresthabijay]

I'm very happy with what I see! The functionality is nearly perfect, and you accounted for the many, spread out changes needed to sync with state, local, and remote.

The suggestions are a combination of code quality recommendations, small bugs, and the use of mutations in existingThoughtChange.

Please run the linter manually (npm run lint) as the automated check is not failing properly.

The only other bug not listed here is the neglect of existingThoughtMove. When a thought is moved (either through drag-and-drop or the keyboard command Ctrl + Shift + Up/Down), it breaks recently edited functionality. The links should be updated as with edit.

onExistingThoughtMove should the lastUpdated timestamp for that thought should be updated as well?

[raineorshine]

Thanks!

A small change needs to be made to ensure this works when editing thoughts in the Context View (Ctrl + Shift + S). When in the context view, the path needs to be linearized into a simple context. pathToContext assumes the given path has already been simplified and doesn't handle this unfortunately.

e.g. Given the following structure:

• A
  • x (cursor)
    • 1
• B
  • x
    • 2

If the cursor is at A • ~x (where ~ indicates the Context View is activated), then the user can navigate to A • ~x • B and B's child A • ~x • B • 2:

• A
  • ~x
    • B
      • 2 (cursor)

In this case, the cursor is A • ~x • B • 2, but the recently edited thought should be B • 2.

This should be as simple as using thoughtsNew instead of cursorNew in existingThoughtChange etc.

Let me know if that doesn't make sense! Thanks!

[shresthabijay]

Thanks!

A small change needs to be made to ensure this works when editing thoughts in the Context View (Ctrl + Shift + S). When in the context view, the path needs to be linearized into a simple context. pathToContext assumes the given path has already been simplified and doesn't handle this unfortunately.

e.g. Given the following structure:

• A

  • x (cursor)

    • 1

• B

  • x

    • 2

If the cursor is at A • ~x (where ~ indicates the Context View is activated), then the user can navigate to A • ~x • B and B's child A • ~x • B • 2:

• A

  • ~x

    • B

      • 2 (cursor)

In this case, the cursor is A • ~x • B • 2, but the recently edited thought should be B • 2.

This should be as simple as using thoughtsNew instead of cursorNew in existingThoughtChange etc.

Let me know if that doesn't make sense! Thanks!

thoughtsNew is a context while cursorNew is path. So we need to convert the thoughtsNew to a path. Is there any utility function that can do that in the current codebase?

[raineorshine]

thoughtsNew is a context while cursorNew is path. So we need to convert the thoughtsNew to a path. Is there any utility function that can do that in the current codebase?

rankThoughtsFirstMatch

[raineorshine]

Can we make this internal to the Breadcrumbs component? I think it makes more sense there than in the Sidebar, which shouldn't be concerned with ellipses.

[shresthabijay]

Yes it makes total sense.