Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation: Fade in new thought #1790

Open
raineorshine opened this issue Jan 19, 2024 · 0 comments · May be fixed by #2589
Open

Animation: Fade in new thought #1790

raineorshine opened this issue Jan 19, 2024 · 0 comments · May be fixed by #2589
Assignees
Labels
bug Something isn't working

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Jan 19, 2024

New Thought has a visual problem in that the bullet and placeholder briefly overlap the next thought until it shifts down.

It has a perceptual problem in that the animation duration is the same duration as larger changes, such as collapse context or toggle table view. For the right "feel", the animation duration should be proportional to the "mass" of the changes, i.e. a T-Rex moves slower than a chicken.

Steps to Reproduce

- a
- c
  1. Set the cursor on a
  2. Activate the New Thought command

Current Behavior

When a new thought is created, the bullet and placeholder briefly overlap the next thought until it shifts down.

Note: The placeholder ("Add a thought") is only shown in training mode, so is not captured in the video.

New.Thought1.mov

Expected Behavior

  1. Speed up the tree-node's transition (normally layoutNodeAnimationDuration) by 50% on New (Sub)Thought only.
  2. Fade in the bullet and placeholder of the new thought with fastDuration or veryFastDuration and ease-in-out so the overlap is less noticeable.
@raineorshine raineorshine added the bug Something isn't working label Jan 19, 2024
@raineorshine raineorshine changed the title Fade in bullet Fade in bullet on new thought May 16, 2024
@raineorshine raineorshine changed the title Fade in bullet on new thought Improve newThought animation Jul 1, 2024
@raineorshine raineorshine changed the title Improve newThought animation Animation: Fade in new thought Nov 2, 2024
@zukilover zukilover linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants