You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When part of a thought is selected, the active state of the toolbar buttons for bold/italic/underline/strikethrought should reflect only the selected text, not the entire thought.
When no text is selected, the toolbar buttons for bold/italic/underline/strikethrough should be active if and only if all the text in the thought is formatted.
There are two incorrect cases given below. Please ensure the solution works for all types of formatting: bold, italic, underline, and strikethrough.
1. No text selected with mixed formatting
Steps to Reproduce
Hello **world**
Current Behavior
The toolbar button for bold is active.
Expected Behavior
The toolbar button for bold should not be active, because the thought has some non-bold characters.
2. Unformatted text selected
Steps to Reproduce
Select the word 'world'.
Current Behavior
Currently, the toolbar button for bold is active, but not for the right reason. Once the above issue is fixed, it will (incorrectly) be inactive.
Expected Behavior
The toolbar button for bold should be active, because all selected characters are bold.
The text was updated successfully, but these errors were encountered:
#2187 partially fixes this by moving tracking of formatting commands to a separate store - triggered by selection changes and commands. In order to fully fix this issue, we would need to remove checks for HTML tags in thought content, e.g. <i>, <b>, etc.
When part of a thought is selected, the active state of the toolbar buttons for bold/italic/underline/strikethrought should reflect only the selected text, not the entire thought.
When no text is selected, the toolbar buttons for bold/italic/underline/strikethrough should be active if and only if all the text in the thought is formatted.
There are two incorrect cases given below. Please ensure the solution works for all types of formatting: bold, italic, underline, and strikethrough.
1. No text selected with mixed formatting
Steps to Reproduce
Current Behavior
The toolbar button for bold is active.
Expected Behavior
The toolbar button for bold should not be active, because the thought has some non-bold characters.
2. Unformatted text selected
Steps to Reproduce
Select the word 'world'.
Current Behavior
Currently, the toolbar button for bold is active, but not for the right reason. Once the above issue is fixed, it will (incorrectly) be inactive.
Expected Behavior
The toolbar button for bold should be active, because all selected characters are bold.
The text was updated successfully, but these errors were encountered: