Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme | update for dockerized server usage #4

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

aviadhahami
Copy link

Pull Request (PR) Checklist

  • I have read the CONTRIBUTING doc
  • PR is from a topic/feature/bugfix branch off the dev branch (right side)
  • PR is against the dev branch (left side)
  • Merlin compiles without errors
  • Passes linting checks and unit tests
  • Updated CHANGELOG
  • Updated README documentation (if applicable)
  • Update Merlin version number in pkg/merlin.go (if applicable)

Change Type

  • Addition
  • Bugfix
  • Modification
  • Removal
  • Security

Description

Merely updating the readme to explain how to use inside a dockerized env :)

ps - I can't amend the commits, so squash on merge :)

Added instruction on how to make Merlin listen to the relevant iface inside container
Pointing to cyberark as needed
@aviadhahami aviadhahami changed the title feature/Update readme for dockerized server usage Readme | update for dockerized server usage Nov 3, 2021
@g3rzi
Copy link

g3rzi commented Nov 4, 2021

Great, thanks Aviad for the contribution :)

@g3rzi g3rzi merged commit 9f68a07 into cyberark:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants