Fixing port when default configuration is selected. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the print with 'http error' in 'PrintPrettyHttpResponse' function.
g3rzi
reviewed
Sep 12, 2022
| @@ -164,7 +164,8 @@ func initConfig() { | |||
| &clientcmd.ConfigOverrides{}, | |||
| ) | |||
| config, err = kubeConfig.ClientConfig() | |||
| if err != nil && len(os.Getenv(clientcmd.RecommendedConfigPathEnvVar)) > 0 { | |||
| // TODO: should fail when YAML is wrong, like with ":" | |||
| if err != nil { //&& len(os.Getenv(clientcmd.RecommendedConfigPathEnvVar)) > 0 { | |||
There was a problem hiding this comment.
You added a comment as part of your checks, I will fix it
g3rzi
approved these changes
Sep 12, 2022
g3rzi
added a commit
that referenced
this pull request
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the print with 'http error' in 'PrintPrettyHttpResponse' function.
Desired Outcome
Fixing port when default configuration is selected.
Fixing the print with 'http error' in 'PrintPrettyHttpResponse' function.
Implemented Changes
Fixing the port issue when default kube config file is selected.
Fixing port when default configuration is selected.
Fixing the print with 'http error' in 'PrintPrettyHttpResponse' function.
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
READMEs) were updated in this PRBehavior
Security