Skip to content

remove bad inverter line, update test #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwhanse merged 2 commits into from
Mar 30, 2018
Merged

remove bad inverter line, update test #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
037755f
remove bad inverter line
wholmgren Mar 30, 2018
0da278b
update example module output
wholmgren Mar 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pvlib/data/sam-library-cec-inverters-2018-3-18.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2505,7 +2505,6 @@ LeadSolar Energy: LS600 [240V] 240V [CEC 2018],240,500,524.883,36,1.95681,-3.049
LeadSolar Energy: LS600ES 277V [CEC 2014],277,600,624.32414,27.03322619,2.57570801,-1.13E-05,-1.34E-04,6.35E-02,0.119358397,0.04,60,19.4,27,45
LeadSolar Energy: LS600ES [277V] 277V [CEC 2018],277,600,624.486,54,2.56291,-1.15006e-005,2.48251e-005,0.0534707,0.122932,0.04,56,11.5646,52,56
LeadSolar Energy: LS600T (208V) 208V [CEC 2014],208,500,527.5554744,35.98932976,2.868916375,-4.73E-05,-1.02E-03,1.57E-02,-5.39E-02,1,60,19.4,27,45
LeadSolar Energy: LS600T [208V] 208V [CEC 2018],208,500,75790.4,36,-nan(ind),1.22899e-07,-0.0251886,-nan(ind),0.0798754,1,45,2105.29,27,45
LeadSolar Energy: LS650S 277V [CEC 2014],277,650,676.7493403,54.0729254,2.38789227,-9.80E-06,-2.17E-04,5.41E-02,6.69E-02,0.04,60,19.4,52,56
LeadSolar Energy: LS650S [277V] 277V [CEC 2018],277,650,676.704,54,2.30605,-8.83925e-006,-0.000202645,0.04063,0.0452291,0.04,56,12.5316,52,56
LeadSolar Energy: LS700S 277V [CEC 2014],277,700,729.7125005,54.07850476,2.024489833,-7.75E-06,-3.55E-04,7.09E-02,0.101741464,0.04,60,19.4,52,56
Expand Down
6 changes: 4 additions & 2 deletions pvlib/test/test_pvsystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,8 @@ def test_calcparams_desoto(cec_module_params):
dEgdT=-0.0002677)

assert_series_equal(np.round(IL, 3), pd.Series([0.0, 6.036], index=times))
assert_allclose(I0, 1.943e-9)
# changed value in GH 444 for 2017-6-5 module file
assert_allclose(I0, 1.94e-9)
assert_allclose(Rs, 0.094)
assert_series_equal(np.round(Rsh, 3), pd.Series([np.inf, 19.65], index=times))
assert_allclose(nNsVth, 0.473)
Expand All @@ -377,7 +378,8 @@ def test_PVSystem_calcparams_desoto(cec_module_params):
IL, I0, Rs, Rsh, nNsVth = system.calcparams_desoto(poa_data, temp_cell)

assert_series_equal(np.round(IL, 3), pd.Series([0.0, 6.036], index=times))
assert_allclose(I0, 1.943e-9)
# changed value in GH 444 for 2017-6-5 module file
assert_allclose(I0, 1.94e-9)
assert_allclose(Rs, 0.094)
assert_series_equal(np.round(Rsh, 3), pd.Series([np.inf, 19.65], index=times))
assert_allclose(nNsVth, 0.473)
Expand Down