🐛 fix(kanban): treat a phantom/deleted PR URL as not_found so it never wedges active_pr

.github/workflows/fork-secret-scan.yml

@@ -0,0 +1,182 @@
+name: Fork Secret Scan
+
+# A hard gate that keeps secrets out of this public fork. The standing rule for
+# the fork is simple and absolute: no secrets, ever. Code lives here; keys live
+# in .env files and Bitwarden, never in a commit.
+#
+# This workflow scans the patch stack — the commits this fork carries on top of
+# its upstream release base — for anything secret-shaped, using gitleaks. It is
+# the always-on companion to the scan baked into fork-daily-sync.yml: that one
+# guards the automated daily update PR, this one guards every other path a
+# commit can reach the integration branch (a hand-pushed branch, a manually
+# opened pull request, a direct push).
+#
+# Scope: it scans only OUR commits, not all of upstream history. The fork point
+# is the base tag recorded in PATCHES.md, so the scan covers exactly the changes
+# we added and nothing upstream already shipped. A finding fails the job, which
+# blocks the pull request — a person has to deal with it before the commit can
+# land.
+#
+# Why install the gitleaks binary directly instead of using the marketplace
+# action: the binary is unencumbered (the action asks for a license key on
+# organization repos), and installing it ourselves lets us scan a precise commit
+# range via --log-opts. The download is pinned to a release version and verified
+# against a published SHA-256, the same way the ripgrep install in
+# fork-daily-sync.yml is pinned.
+
+on:
+  pull_request:
+    branches:
+      - cwest/integration
+  push:
+    branches:
+      - cwest/integration
+  workflow_dispatch:
+    inputs:
+      full_history:
+        description: 'Scan the entire git history instead of only the carried patch stack.'
+        type: boolean
+        default: false
+
+permissions:
+  contents: read
+
+# One scan per ref at a time; newer pushes supersede an in-flight scan.
+concurrency:
+  group: fork-secret-scan-${{ github.ref }}
+  cancel-in-progress: true
+
+env:
+  GITLEAKS_VERSION: 8.30.1
+  # SHA-256 of gitleaks_8.30.1_linux_x64.tar.gz, from the release checksums file.
+  GITLEAKS_SHA256: 551f6fc83ea457d62a0d98237cbad105af8d557003051f41f3e7ca7b3f2470eb
+
+jobs:
+  secret-scan:
+    name: Scan carried patches for secrets
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+    steps:
+      - name: Checkout (full history)
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6.0.2
+        with:
+          # Need full history so the base-tag..HEAD range resolves and gitleaks
+          # can walk the carried commits.
+          fetch-depth: 0
+          fetch-tags: true
+
+      - name: Install gitleaks (pinned, checksum-verified)
+        run: |
+          set -euo pipefail
+          tarball="gitleaks_${GITLEAKS_VERSION}_linux_x64.tar.gz"
+          url="https://github.com/gitleaks/gitleaks/releases/download/v${GITLEAKS_VERSION}/${tarball}"
+          curl -sSfL -o "$tarball" "$url"
+          echo "${GITLEAKS_SHA256}  ${tarball}" | sha256sum -c -
+          tar -xzf "$tarball" gitleaks
+          sudo mv gitleaks /usr/local/bin/gitleaks
+          rm -f "$tarball"
+          gitleaks version
+
+      - name: Determine the commit range to scan
+        id: range
+        run: |
+          set -euo pipefail
+          # Default: scan only the carried patch stack, base..HEAD. The base is
+          # the fork point recorded in PATCHES.md. Scanning from there covers
+          # exactly our commits and skips upstream history, which is both faster
+          # and avoids flagging anything that is upstream's problem, not ours.
+          #
+          # The fork tracks upstream `main` HEAD, so the base is normally a
+          # commit SHA (recorded as an HTML comment `<!-- Base commit: <sha> -->`
+          # in PATCHES.md). For backward compatibility we also accept a release
+          # tag (`Base tag: vX.Y.Z`). A SHA is preferred when both are present.
+          if [ "${{ github.event.inputs.full_history }}" = "true" ]; then
+            echo "mode=full" >> "$GITHUB_OUTPUT"
+            echo "Scanning full git history (manual override)."
+            exit 0
+          fi
+
+          # Prefer a commit SHA (main-tracking model).
+          base_sha="$(grep -m1 'Base commit:' PATCHES.md \
+            | grep -oE '[0-9a-f]{7,40}' \
+            | head -1 || true)"
+          base_ref=""
+          if [ -n "${base_sha}" ]; then
+            if git rev-parse -q --verify "${base_sha}^{commit}" >/dev/null; then
+              base_ref="${base_sha}"
+            else
+              echo "::error::Base commit ${base_sha} from PATCHES.md is not in the repository (fetch-depth too shallow, or the base was not pushed)."
+              exit 1
+            fi
+          else
+            # Fallback: a release tag (legacy tag-pinned model).
+            base_tag="$(grep -m1 'Base tag:' PATCHES.md \
+              | grep -oE 'v[0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?' \
+              | head -1 || true)"
+            if [ -z "${base_tag}" ]; then
+              echo "::error::Could not read a base (Base commit / Base tag) from PATCHES.md; cannot scope the scan."
+              exit 1
+            fi
+            if ! git rev-parse -q --verify "refs/tags/${base_tag}" >/dev/null; then
+              echo "::error::Base tag ${base_tag} from PATCHES.md is not in the repository."
+              exit 1
+            fi
+            base_ref="refs/tags/${base_tag}"
+          fi
+
+          echo "mode=range" >> "$GITHUB_OUTPUT"
+          echo "base_ref=${base_ref}" >> "$GITHUB_OUTPUT"
+          echo "Scanning carried patch stack: ${base_ref}..HEAD"
+          git log --oneline "${base_ref}..HEAD" || true
+
+      - name: Scan for secrets
+        run: |
+          set -euo pipefail
+          # gitleaks exits 0 when clean, 1 when it finds a leak (the gate), and
+          # >1 on an internal error. A SARIF report is written for the run log.
+          common_args=(
+            --redact
+            --report-format sarif
+            --report-path gitleaks-report.sarif
+            --verbose
+            --exit-code 1
+          )
+
+          if [ "${{ steps.range.outputs.mode }}" = "full" ]; then
+            gitleaks git . "${common_args[@]}"
+          else
+            base_ref="${{ steps.range.outputs.base_ref }}"
+            # --log-opts is passed straight to `git log`, scoping the scan to the
+            # carried commits only.
+            gitleaks git . "${common_args[@]}" \
+              --log-opts="${base_ref}..HEAD"
+          fi
+          echo "No secrets found in the scanned commits."
+
+      - name: Upload scan report
+        if: always()
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02  # v4.6.2
+        with:
+          name: gitleaks-report
+          path: gitleaks-report.sarif
+          if-no-files-found: ignore
+          retention-days: 14
+
+      - name: Result summary
+        if: always()
+        run: |
+          {
+            echo "## Fork secret scan"
+            echo ""
+            echo "- Scanner: gitleaks v${GITLEAKS_VERSION}"
+            echo "- Mode: \`${{ steps.range.outputs.mode }}\`"
+            if [ "${{ steps.range.outputs.mode }}" = "range" ]; then
+              echo "- Range: \`${{ steps.range.outputs.base_ref }}..HEAD\` (carried patch stack)"
+            fi
+            echo "- Outcome: \`${{ job.status }}\`"
+            echo ""
+            echo "A failure here means something secret-shaped is in a carried commit."
+            echo "Rotate the value, rewrite the offending commit to remove it, and"
+            echo "force-push the cleaned branch. Never just delete the line in a new"
+            echo "commit — the secret stays in history and must be treated as leaked."
+          } >> "$GITHUB_STEP_SUMMARY"