Repository navigation
chore: retarget to net10.0 and upgrade EF Core family to 10.0.13 - #194
Conversation
net8.0 LTS ends Nov 2026; net10.0 is required for the EF Core 10 upgrade. CI dotnet-version pins and hardcoded net8.0 bin paths updated with it.
Unblocks the deferred Microsoft.Data.Sqlite 10 bump (ex-PR #174) now that the Game targets net10.0; removes the dependabot ignore rule.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the primary changes: retargeting projects to .NET 10 and upgrading the EF Core family to 10.0.13. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (13 skipped: 13 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <TargetFramework>net10.0</TargetFramework> |
There was a problem hiding this comment.
🔍 Automation tests retain a .NET 8 runtime dependency
Retargeting this suite leaves CreateChildFixture generating net8.0 children. CI explicitly installs only .NET 10, so test execution still depends on a separately available .NET 8 runtime.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Review of Devin's findings (assessment, since main reverted to net8.0 and both findings are net10-scoped):
Both are captured for the eventual |
Devin-review findings on #194: GameProcessDriverTests child fixture and bin paths, VideoRecorder ProgramTests fixture, the RecorderPlatformPreflight fallback + comments and its test matrix, the macOS OBS setup guide, and the CLAUDE.md repo instructions. Historical plans/specs/verification records intentionally left as written.
1 participant
Re-submission of #192, which was reverted from main at maintainer request (main reset to
fb778b93). Same two commits, presented as a PR for review instead of landing directly.Two commits, in order:
1. Retarget to net10.0
net8.0→net10.0(Game.Windowsnet10.0-windows, E2Enet10.0-windows7.0)dotnet-version: '8.0.x'→'10.0.x'(build-and-test ×4, release ×2), two hardcodedbin/Debug/net8.0MMTools paths updated2. EF Core family 9.0.20 → 10.0.13
Microsoft.EntityFrameworkCore.Sqlite,Microsoft.EntityFrameworkCore.Tools,Microsoft.Data.Sqlitein both Game csprojs — same-major pairing throughout, finally taking what Bump Microsoft.Data.Sqlite from 9.0.20 to 10.0.12 #174 wanteddependabot.yml: ignore rule forMicrosoft.Data.Sqlite10.x removedVerification (from the identical tree that briefly sat on main as #192)
Known notes
RecorderPlatformPreflight.csdoc comments and a diagnostics-onlynet8.0fallback string are stale but harmless (fallback fires only when the csproj is unreadable, in which case the gate fails anyway)release.ymlSDK bump is not exercised by PR CI (release is manual dispatch); first release run will prove itSummary by CodeRabbit