Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Follow the version of cmake #9

Merged
merged 5 commits into from
Oct 19, 2023
Merged

build: Follow the version of cmake #9

merged 5 commits into from
Oct 19, 2023

Conversation

paleahn
Copy link
Collaborator

@paleahn paleahn commented Oct 10, 2023

Delete command which requires cmake 3.24.

@paleahn paleahn requested a review from cwahn as a code owner October 10, 2023 04:02
cwahn
cwahn approved these changes Oct 19, 2023
View reviewed changes
Copy link
Owner

@cwahn cwahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the branch also works on Mac and clang as well. Merging the branch.

@cwahn cwahn merged commit 4272407 into main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwahn cwahn cwahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paleahn @cwahn