Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new paper bibtex, fix docstring, add PR template #99

Merged
merged 8 commits into from
Jan 14, 2025

Conversation

dylanbouchard
Copy link
Collaborator

@dylanbouchard dylanbouchard commented Jan 9, 2025

This PR does the following:

  • Add bibtex for new software paper on arXiv
  • fix docstring in CounterfactualGenerator.check_ftu
  • add PR template
  • upgrade version of jinja2 for security patch

@dylanbouchard
Copy link
Collaborator Author

dylanbouchard commented Jan 9, 2025

@mohitcek, @dskarbrevik, @virenbajaj can one of you please review this PR?

Copy link
Contributor

@mohitcek mohitcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this PR

<!--- Mention related issues, pull requests, or discussions with #<issue/PR/discussion ID>. -->
<!--- Tag people for whom this PR may be of interest using @<username>. -->

## Contributor License Agreement
Copy link
Collaborator Author

@dylanbouchard dylanbouchard Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@the-real-pdf, what do you think about including this in the PR template? It seems more efficient than asking each new contributor if they have signed the CLA in the comments of their PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved via email

@dylanbouchard dylanbouchard merged commit 42836a3 into develop Jan 14, 2025
18 checks passed
@dylanbouchard dylanbouchard deleted the db/add_bibtex branch January 15, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants