Release v2.21.1 #8559
Merged
Release v2.21.1 #8559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cvat-bot[bot]](https://avatars.githubusercontent.com/in/406724?s=60&v=4){kind=small}
Update develop after v2.21.0
<!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> The pr adds shortcuts to actions in brush tool panel (in mask editing mode)  ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [x] I have added tests to cover my changes - ~~[ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))~~ - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced keyboard shortcuts for various brush tools, enhancing user efficiency. - Added tooltips displaying keyboard shortcuts for better usability. - Implemented a `LabelSelector` component for improved label selection. - **Improvements** - Updated sorting logic for shortcut settings to organize items by their defined weights. - **Refactor** - Enhanced state management and control flow for brush tool interactions. - Added a new optional `weight` property to the key mapping interface for better customization. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
… and step (#8551) To address the identified issue, we likely need to store relative frame numbers in self._required_frames. Explanation: The only place where self._required_frames is used is in the method: ``` def _is_frame_required(self, frame): return self._required_frames is None or frame in self._required_frames ``` This method is called in: ``` def get_included_frames(self): return set( i for i in self.rel_range if not self._is_frame_deleted(i) and not self._is_frame_excluded(i) and self._is_frame_required(i) ) ``` Currently, the implementation tries to check whether a relative frame number exists in a set that contains absolute frame numbers, which doesn't work if start_frame or frame_step is defined when the task is created. This causes failures in both quality reports and immediate feedback, as well as possibly other functionalities that rely on get_included_frames. Another issue with the current code is a logical inconsistency: ``` abs_range = self.abs_range self._required_frames = set( self.abs_frame_id(frame) for frame in self._required_frames if frame in abs_range ) ``` Here, abs_frame_id expects a relative frame number and converts it to an absolute frame number, but we first check if the relative frame number from self._required_frames is already in the absolute range, which is incorrect.
…8555) <!-- Raise an issue to propose your change (https://github.com/cvat-ai/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have created a changelog fragment <!-- see top comment in CHANGELOG.md --> - [ ] I have updated the documentation accordingly - [ ] I have added tests to cover my changes - [ ] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved video processing stability by disabling threading in video reading classes, addressing potential memory management issues. - **New Features** - Enhanced video handling capabilities with updated threading parameters for better performance during video processing. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
cvat-bot
bot
requested review from
azhavoro,
zhiltsov-max,
bsekachev,
SpecLad and
Marishka17
as code owners
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8559 +/- ##
==========================================
+ Coverage 74.22% 74.26% +0.04%
==========================================
Files 400 400
Lines 43207 43224 +17
Branches 3905 3909 +4
==========================================
+ Hits 32069 32101 +32
+ Misses 11138 11123 -15
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Fixed
Ground truth tracks are displayed not only on GT frames in review mode (Fixed: Ground truth tracks are displayed not only on GT frames in review mode #8531)
Incorrect navigation by keyframes when annotation job ends earlier than track in a ground truth job (Fixed frames navigation and GT tracks displaying #8533)
Tracks from a ground truth job displayed on wrong frames in review mode when frame step is not equal to 1 (Fixed frames navigation and GT tracks displaying #8533)
Task creation with cloud storage data and GT_POOL validation mode (Fix task creation with
gt_poolvalidation and cloud storage data #8539)Incorrect quality reports and immediate feedback with non default start frame or frame step (Fixed quality reports and immediate feedback on jobs with start frame and step #8551)
av context closing issue when using AUTO thread_type (Workaround for av context closing issue when using AUTO thread_type #8555)