Fix spurious failures in case_17_lock_hide_features.js
#7742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69682f2 changed the sidebar layout in such a way that mousing over the "Switch hidden property" button for an object can show a tooltip that obscures the "Switch hidden property for all" button. This is exactly what happens in this test. The test is supposed to work around this, by hiding the tooltips before each section, but the workaround is insufficiently robust, because it can fire before the tooltip is shown. Fix this by taking another workaround from `issue_2485_navigation_empty_frames.js`, moving it into the `hideTooltips` command, and then using that command in `case_17_lock_hide_features.js`.
bsekachev
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
#7654 changed the sidebar layout in such a way that mousing over the "Switch hidden property" button for an object can show a tooltip that obscures the "Switch hidden property for all" button. This is exactly what happens in this test at the end of the "Go to polygon" section.
The test is supposed to work around this, by hiding the tooltips before each section, but the workaround is insufficiently robust. Sometimes, the workaround executes before the tooltip is shown, so it does nothing. Then the tooltip appears and covers up the "Switch hidden property for all" button. Then the next section tries to click this button, and fails.
Fix this by taking another workaround from
issue_2485_navigation_empty_frames.js, moving it into thehideTooltipscommand, and then using that command incase_17_lock_hide_features.js.How has this been tested?
Checklist
developbranch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.