Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch of fixes #2031

Merged
merged 8 commits into from
Aug 19, 2020
Merged

Batch of fixes #2031

merged 8 commits into from
Aug 19, 2020

Conversation

ActiveChooN
Copy link
Contributor

@ActiveChooN ActiveChooN commented Aug 13, 2020

Motivation and context

Added Open task button for task creation notification
Added links to header buttons. Related to #1419
Fixed #2015
Fixed #1054

How has this been tested?

Manually

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@ActiveChooN ActiveChooN added the bug Something isn't working label Aug 13, 2020
@ActiveChooN
Copy link
Contributor Author

@azhavoro, have an issue with CI, could you look at it?

@azhavoro
Copy link
Contributor

@azhavoro, have an issue with CI, could you look at it?

@ActiveChooN The validate_labels method should return the validated value. I guess this is the reason for the failed CI tests.

@coveralls
Copy link

coveralls commented Aug 17, 2020

Pull Request Test Coverage Report for Build 6996

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • 182 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.8%) to 69.721%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cvat/apps/engine/serializers.py 5 7 71.43%
Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 2 76.99%
datumaro/datumaro/components/algorithms/rise.py 5 90.7%
datumaro/datumaro/cli/main.py 11 0%
datumaro/datumaro/cli/util/init.py 15 27.59%
datumaro/datumaro/components/extractor.py 24 91.8%
datumaro/datumaro/components/operations.py 55 90.55%
datumaro/datumaro/components/project.py 70 80.0%
Totals Coverage Status
Change from base Build 6913: 0.8%
Covered Lines: 11725
Relevant Lines: 16363

💛 - Coveralls

@ActiveChooN ActiveChooN changed the title Label name unique validator Batch of fixes Aug 17, 2020
@bsekachev
Copy link
Member

@ActiveChooN

Looks like some of cypress tests have broken. Could you please look why?

@dvkruchinin
Copy link
Contributor

@ActiveChooN

Looks like some of cypress tests have broken. Could you please look why?

I'll answer if you don't mind.
Currently, cypress is looking for a button with the value "tasks" to go to the list of tasks after creating an annotation task.
The button looks like this

<button value="tasks" type="button" class="ant-btn cvat-header-button ant-btn-link"><span>Tasks</span></button>

In this PR the button becomes a link

<a value="tasks" href="/tasks?page=1" class="ant-btn cvat-header-button ant-btn-link"><span>Tasks</span></a>

This error can be resolved by changing line 37 in the file tests/cypress/support/commands.js
from

cy.get('button[value="tasks"]').click()

to

cy.get('[value="tasks"]').click()

@ActiveChooN
Copy link
Contributor Author

@dvkruchinin, thanks a lot.

@bsekachev bsekachev merged commit 582e23b into develop Aug 19, 2020
@ActiveChooN ActiveChooN deleted the dk/batch_of_fixes branch August 24, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants