Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React UI: tags support #1241

Merged
merged 14 commits into from
Mar 16, 2020
Merged

React UI: tags support #1241

merged 14 commits into from
Mar 16, 2020

Conversation

ActiveChooN
Copy link
Contributor

@ActiveChooN ActiveChooN commented Mar 6, 2020

Added tags support to new UI

Now you can add tags to annotation with button on the sidebar
image

And edit it with objects panel like other objects
image
TODO:

  • Fix filters
  • Fix Ctrl+C N shortcuts
  • Add color changing
  • Fix objects hiding
  • add tags drawing to cvat-canvas

@ActiveChooN ActiveChooN changed the title [WIP] React UI: tags support React UI: tags support Mar 6, 2020
@bsekachev
Copy link
Member

Hi, some found issues:

  1. Probably we should not display buttons "to background", "to foreground" at all for tags.
  2. Filter doesn't work
  3. Changing color for a tag doesn't work
  4. N shortcut to create new tag doesn't work
  5. Ctrl+C, Ctrl+B shortcuts don't work
  6. Hide/show all button doesn't work correctly (try to create tag and hide/show all)
  7. Left/Right arrow buttons (search with a filter) don't work correctly if there is a tag on a found frame (I mean next or previous)

@ActiveChooN
Copy link
Contributor Author

Changing color for a tag doesn't work

Tags are not displayed on canvas so maybe no color changer is needed

@ActiveChooN
Copy link
Contributor Author

@bsekachev fixed issues, can you make review again?

@bsekachev
Copy link
Member

Sure.
A couple of issues with copy:

  1. Ctrl + V works only once after Ctrl + C. Is it expected?
  2. It seems to be attributes aren't copied from source tag.

@vinorth-v
Copy link

Hello, can you give an estimation of when the tags would be merged? One week? One month? more?

Thank you,
Best regards

@ActiveChooN
Copy link
Contributor Author

@vinorth05, thank you for your interest in CVAT project. I guess this PR will be finished and merged in few days

@ActiveChooN ActiveChooN merged commit 6a7bf6d into develop Mar 16, 2020
@ActiveChooN ActiveChooN deleted the dk/cvat-ui-tags branch March 16, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants