-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added options to the module - sort, order #40
Conversation
If we are doing this in the module, we should probably also remove the |
as |
If you could do that in this PR we can land it 👍 |
did it |
A few notes on this:
Here's an image of what happens when I pass We need to handle |
Since we've got some open PRs that can currently land and were waiting on this one as 0.15.0, I've changed this to 0.16.0 and am going to ship another as 0.15.0 for now 👍 |
Going to remove the milestone for now until this is ready to land, at which point it will be whatever the next minor is. |
@maddhruv is this still a goal? If so, can it be cleaned up? If not, can it be closed? 🙏 |
as of now |
No description provided.