handle ENOTFOUND errors and ask users to report all other errors; #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @bnb |
|
Oi, sorry for not seeing this. Will take a look this weekend ❤️ |
|
@bnb no hurry, I know how it is |
|
Created some issues on the buggin repo. Would love to see them addressed before merging 👍 |
boneskull
force-pushed
the
issue/78
branch
2 times, most recently
from
8412038
to
fe02cec
Compare
cutenode#78 This PR will ask users to report unhandled rejections or uncaught exceptions to the project issue tracker. - added a test to check this is working - added dev dep [execa](https://npm.im/execa) for said test - added [buggin](https://npm.im/buggin) unexpected error output
|
@bnb this is updated with your requested changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will ask users to report unhandled rejections or uncaught exceptions to the project issue tracker. It also detects a DNS or network problem and prints a nicer message instead.
package.jsonwith correct repo infoIf the user is disconnected from the network:
If something else bad happens:
(This example problem arises if the repo simply doesn't exist on GitHub, which should probably be explicitly handled by
good-first-issue.)When clicking the link, the user will be taken to something like this:
The link is displayed in full (big querystring) if the terminal does not support link rendering, which is most stuff except iTerm, afaik.
Refs: #80