Option for variable expansion when setting environment variables #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… quotation method of the exported value
|
I'm 👎. Even though "$PATH" doesn't get expanded to it's value, the env will read it that way in the end. |
|
I'm not sure I understand, although I am not the most knowledgeable in this area so I may be missing a trick. My apologies in advance if this is the case. Adding PATH through |
|
Ah yea. You're right |
sethvargo
added a commit
that referenced
this pull request
Jan 19, 2014
- Refactor providers to support whyrun mode - Package custom ChefSpec matchers - Add Test Kitchen integration test - Update ChefSpec tests - Expand environment variables (like `$PATH`) (#6) - Add Rakefile for running tests - Use the latest and greatest testing strategies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
expandoption tomagic_shell_environmentto switch the quotes from single to double, so variables withinvaluecan be expanded. An example of where this might be useful is setting$PATH, previously avalueof "/my/custom/path:$PATH" would not be expanded.I made this an option rather than simply replacing the quotation directly as some existing users may depend on the lack of expansion.