Add extra device data to attributes object in addDevice
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanderberkein
changed the title
addDeviceaddDevice
mike-engel
requested changes
Sep 14, 2022
lib/track.ts
Outdated
| @@ -116,7 +116,7 @@ export class TrackClient { | |||
| } | |||
|
|
|||
| return this.request.put(`${this.trackRoot}/customers/${encodeURIComponent(customerId)}/devices`, { | |||
| device: { id: device_id, platform, ...data }, | |||
| device: { id: device_id, platform, attributes: { ...data } }, | |||
There was a problem hiding this comment.
While you're here @xanderberkein, let's add support for last_used here:
Suggested change
| device: { id: device_id, platform, attributes: { ...data } }, | |
| let { last_used, ...attributes } = data; | |
| device: { id: device_id, platform, last_used, attributes }, |
There was a problem hiding this comment.
@mike-engel added in my latest commit
mike-engel
previously approved these changes
Sep 15, 2022
|
@mike-engel I've made it so that |
mike-engel
approved these changes
Sep 16, 2022
|
Thanks @xanderberkein, this should be available in |
|
Great, thanks! |
|
@mike-engel It seems like you didn't include the build ( |
|
Hmm, looks like npm doesn't run the |
|
Should be fixed in |
|
@mike-engel Works now, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add extra data to a device, we should use the
attributesparam in the add/update device API call (see the official docs)Currently, extra data gets spread out over the request params and it doesn't arrive in customer.io.
This PR makes sure that data that's passed along through the
dataparam in theaddDevicefunction, is properly sent to the API by putting it in the requiredattributesparam.