Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for showing the minimum and maximum values #10

Merged
merged 13 commits into from
Jun 15, 2019
Merged

Add support for showing the minimum and maximum values #10

merged 13 commits into from
Jun 15, 2019

Conversation

TheLastProject
Copy link
Contributor

I quite like the bar card, but I'd like to display my weather on it with the current temperature and today's low and high.

I messed around a bit and I believe this is a rather clean way to make cases like this possible that, as far as I have tested, doesn't break anything.

Example:
image

I've been trying changes incrementally, so please squash these commits together if you do want to accept these changes :)

@Gluwc
Copy link
Member

Gluwc commented Jun 14, 2019

Hey this is a pretty cool idea, I'll try to integrate it tomorrow.

Noticed an issue with the alignment of the value when using the split option together with an icon.

Old

image

New

image

- type: custom:bar-card
  icon_position: inside
  align: split
  indicator: right
  entities:
    - sensor.lucas_phone_battery

@TheLastProject
Copy link
Contributor Author

I think I fixed that regression. Can you please check if all behaviour is as you expect it to be now?

@Gluwc Gluwc merged commit f30f113 into custom-cards:master Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants