Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/curvegrid/hardhat-multibaas-plugin/blob/main/src/deploy.ts#L62
const requestURL = new URL(path, this.mbConfig.host);
In order to not URL a URL, we should make the
mbConfig
host
a string. Or alternatively, we could have modified the line above to dothis.mbConfig.host.toString()
before making it a URL again.If we keep the type as a URL, then it is an extra import required in the hardhat config, so personally I think we should just make it a string.