Skip to content

Conversation

@DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Aug 22, 2025

  • We currently use the API data to calculate the USD rate of a specific token
  • However, we use some complicated querying to retrieve it at query time, while that's not necessary
  • Instead, we can use react-query to retrieve the usd rates as wished
  • Also we can add some proper loading skeletons

@vercel
Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
curve-dapp Ready Ready Preview Comment Sep 2, 2025 8:58am
curve-dapp-storybook Ready Ready Preview Comment Sep 2, 2025 8:58am

0xAlunara
0xAlunara previously approved these changes Aug 27, 2025
Copy link
Collaborator

@0xAlunara 0xAlunara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted for now as it's an improvement regardless, but yeah we might have to streamline the multiple token usd rate queries at a later point

OnlyJousting
OnlyJousting previously approved these changes Aug 28, 2025
0xAlunara
0xAlunara previously approved these changes Aug 29, 2025
OnlyJousting
OnlyJousting previously approved these changes Aug 30, 2025
pilotvietnam
pilotvietnam previously approved these changes Sep 1, 2025
0xtutti
0xtutti previously approved these changes Sep 1, 2025
0xAlunara
0xAlunara previously approved these changes Sep 1, 2025
@DanielSchiavini DanielSchiavini merged commit 8341f5d into main Sep 2, 2025
11 of 12 checks passed
@DanielSchiavini DanielSchiavini deleted the stablecoin branch September 2, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants