Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added member scope type #954

Closed
wants to merge 7 commits into from
Closed

Added member scope type #954

wants to merge 7 commits into from

Conversation

AndreasArvidsson
Copy link
Member

Checklist

@pokey
Copy link
Member

pokey commented Sep 12, 2022

Interesting. A few questions:

parentheses pairing

What happens with something like the following?

foo.bar() + baz()

If cursor is on foo, won't it take the whole thing, because it eats until it hits a closing )? I think we want just foo.bar() in that case

multi line / whitespace

Does this support line breaks inside a function call, eg

foo(
  bar + 5
)

With cursor on foo. Looks like it does, but test would be good

Does this support line breaks / spaces between the accesses? Eg for a long chain I'll do

foo
.bar
.baz

other

What happens in C++ for :: and ->?

What about square brackets?

What about js template strings? Eg

foo.bar`baz bongo`

Does this work with Unicode identifiers?

Does this work with snake case identifiers?

@AndreasArvidsson
Copy link
Member Author

This needs to be implemented using the syntax tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants