-
-
Notifications
You must be signed in to change notification settings - Fork 91
Move to monorepo #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to monorepo #510
Conversation
…s-talon.git cursorless-talon subrepo: subdir: "cursorless-talon" merged: "afa65b88" upstream: origin: "https://github.com/cursorless-dev/cursorless-talon.git" branch: "main" commit: "afa65b88" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
| push-cursorless-talon: | ||
| name: Push cursorless-talon subrepo | ||
| runs-on: ubuntu-latest | ||
| needs: publish-extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We make sure extension publication was successful before pushing talon side so that users don't end up with new talon files but old extension
| steps: | ||
| - uses: actions/checkout@v2 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do deep clone so that we can use it for our git push
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: cursorless-dev/cursorless-talon | ||
| token: ${{ secrets.CURSORLESS_BOT_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now have a bot 🤖. Only the bot is allowed to push to main on cursorless-talon now
.github/workflows/deploy.yaml
Outdated
| - name: Checkout cursorless-talon | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| repository: cursorless-dev/cursorless-talon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice we moved cursorless-talon into a new cursorless-dev organization, because that's the only way to make it so that only certain users can push to a branch
| @@ -0,0 +1 @@ | |||
| * @pokey No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the files under cursorless-talon just come from the main branch there
| @@ -0,0 +1,10 @@ | |||
| name: Lint | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we need to run linting there as well 🤔
| @@ -0,0 +1,12 @@ | |||
| ; DO NOT EDIT (unless you know what you are doing) | |||
| ; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is the file generated by git-subrepo. Keeps track of all the information needed for pushing. Pretty cool
* git subrepo clone (merge) https://github.com/cursorless-dev/cursorless-talon.git cursorless-talon subrepo: subdir: "cursorless-talon" merged: "afa65b88" upstream: origin: "https://github.com/cursorless-dev/cursorless-talon.git" branch: "main" commit: "afa65b88" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596" * Set up tests and deploy for cursorless talon subrepo * Cleaner solution
Fixes #475
Fixes #17