add dart class support #2677
Merged
add dart class support #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
reviewed
Nov 10, 2024
queries/dart.scm
Outdated
Comment on lines
24
to
30
| (class_definition | ||
| name: (_) @className | ||
| ) | ||
| (class_definition | ||
|
|
||
| name: (_) @className | ||
| ) |
queries/dart.scm
Outdated
|
|
||
| name: (_) @className | ||
| ) | ||
| ] @class |
There was a problem hiding this comment.
The domain of class name should be the whole class, so that you can say "class name" from anywhere in the class
Note you'll need to rerun update fixtures after this change
Suggested change
| ] @class | |
| ] @class @className.domain |
pokey
reviewed
Nov 10, 2024
queries/dart.scm
Outdated
| ( | ||
| [ | ||
| (class_definition | ||
|
|
There was a problem hiding this comment.
this empty line shouldn't appear. Have you installed all the recommended extensions? In particular, Andreas's vscode extension should autoformat .scm files. Though maybe you need to configure it to be the formatter for .scm files?
pokey
reviewed
Nov 11, 2024
queries/dart.scm
Outdated
Comment on lines
21
to
27
| ( | ||
| [ | ||
| (class_definition | ||
| name: (_) @className | ||
| ) | ||
| ] @class @className.domain | ||
| ) |
There was a problem hiding this comment.
nitpicking here, but I believe you can remove both the square brackets and outer parens:
Suggested change
| ( | |
| [ | |
| (class_definition | |
| name: (_) @className | |
| ) | |
| ] @class @className.domain | |
| ) | |
| (class_definition | |
| name: (_) @className | |
| ) @class @className.domain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist