Added visible modifier #2094
Added visible modifier #2094
Conversation
| } | ||
|
|
||
| function openEditor() { | ||
| return openNewEditor("// 1\n\nfunction myFunk() {\n\t// 2\n}\n\n// 3", { |
There was a problem hiding this comment.
this would be much clearer as a constant like
const content = `
function myFunk() {
...
}You could strip it if you don't want leading / trailing newline
|
fixed |
| import { PlainTarget } from "../targets"; | ||
|
|
||
| export class VisibleStage implements ModifierStage { | ||
| constructor(private modifier: VisibleModifier) {} |
There was a problem hiding this comment.
not worth changing for this PR, esp since we do this all over the place, but don't feel compelled to pass in modifier if it's not actually used. Gives a nice signal we don't use it if we don't even pass it in. I think one of the benefits of our DI setup is that we don't enforce uniformity like other DI mechanisms
There was a problem hiding this comment.
Interesting. I kinda had the opposite reaction. If we force a modifier of the correct type then we can't accidentally in the previous switch statement instantiate the wrong modifier. The more strictly typed the better?
There was a problem hiding this comment.
Yeah I guess that's fair; hadn't thought bout that
Fixes #1607 Tested with `"from visible chuck every instance air"` and folded regions will be untouched. ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
Fixes cursorless-dev#1607 Tested with `"from visible chuck every instance air"` and folded regions will be untouched. ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
3 participants
Fixes #1607
Tested with
"from visible chuck every instance air"and folded regions will be untouched.Checklist