bump typescript => 5.2.2; migrate to ESM

[pokey]

Checklist

• [-] I have added tests
• [-] I have updated the docs and cheatsheet
• I have not broken the cheatsheet
• Check source maps are working for extension
• Check source maps are working in test files
• Don't depend on esbuild in all packages?
• Try running vsix from CI locally
• [-] Use two .. for update recorded tests script

[auscompgeek]

Heh, I anticipated the build failing the moment I saw the PR title 😂

[auscompgeek]

We need to bump typescript-eslint and prettier before typescript anyway.

[pokey]

We need to bump typescript-eslint and prettier before typescript anyway.

would you recommend doing that in a separate PR or combine with this one?

[auscompgeek]

Our typescript-eslint version disagrees with our current typescript version anyway, so we need to bump it regardless.

[pokey]

...and we're green!! 🙌

But do give stuff a whirl locally on windows @AndreasArvidsson to make sure it works for you 😅

(don't forget to do a pnpm install and pnpm clean)

[AndreasArvidsson]

No my-ts-node still isn't working for me

> @cursorless/[email protected] preprocess-svg-hats C:\Users\andre\repositories\cursorless\packages\cursorless-vscode
> my-ts-node src/scripts/preprocessSvgHats.ts

'C:\Program' is not recognized as an internal or external command,

I'm working on a solution

[AndreasArvidsson]

@pokey After I fixed the support for absolute paths in my latest commit I still can't run scripts like preprocess hats because CURSORLESS_REPO_ROOT is missing from the environmental variables

> @cursorless/[email protected] preprocess-svg-hats C:\Users\andre\repositories\cursorless\packages\cursorless-vscode
> my-ts-node src/scripts/preprocessSvgHats.ts

C:\Users\andre\repositories\cursorless\packages\common\src\testUtil\getCursorlessRepoRoot.ts:9
    throw new Error(
          ^


Error: CURSORLESS_REPO_ROOT environment variable must be set to run this script

[AndreasArvidsson]

Ok that is fixed now. I must say I'm not a big fan of having to add these really complicated run scripts with env.

[pokey]

Yeah it's the whole __dirname thing. I wish esbuild supported that properly. Basically if you're using a bundler, tho, you can't really rely on it, so it's always been a bit dicey for us. We could prob look into it in a follow up. Maybe there's some esbuild plugin we could use

Maybe something like evanw/esbuild#859 (comment)

[pokey]

We could switch to using cross-spawn. That's more robust and I believe supports spaces. Or I could go back to my bash script for my-ts-node. Translating it to a node script was a Hail Mary that I thought would help windows CI and turned out to be totally irrelevant but I left it because js is a bit easier to read

[AndreasArvidsson]

I definitely prefer javascript over bash

[pokey]

Yeah it's the whole __dirname thing. I wish esbuild supported that properly. Basically if you're using a bundler, tho, you can't really rely on it, so it's always been a bit dicey for us. We could prob look into it in a follow up. Maybe there's some esbuild plugin we could use

Maybe something like evanw/esbuild#859 (comment)

I guess we could also use a heuristic like looking for a .git directory and a couple child files we know should be in root

But basically the old way was pretty dicey. Eg we were relying on the fact that transpiled code was at same level of nesting, etc

[AndreasArvidsson]

Yeah it's the whole __dirname thing. I wish esbuild supported that properly. Basically if you're using a bundler, tho, you can't really rely on it, so it's always been a bit dicey for us. We could prob look into it in a follow up. Maybe there's some esbuild plugin we could use
Maybe something like evanw/esbuild#859 (comment)

I guess we could also use a heuristic like looking for a .git directory and a couple child files we know should be in root

But basically the old way was pretty dicey. Eg we were relying on the fact that transpiled code was at same level of nesting, etc

meta updater just looks for pnpm-lock.yaml

[pokey]

Yeah that could work. Would make the function need to be async or I guess just read synchronously

Or we could bake computing the env var into the my-ts-node script now that we own it

[pokey]

ok @AndreasArvidsson have a look at my latest changes and lmk if things still work locally for you; I

• switched from vanilla node spawn to cross-spawn in an effort to make spawning more robust,
• set CURSORLESS_REPO_ROOT from my-ts-node
• added lint rule to ensure we keep up with all the esm stuff

[AndreasArvidsson]

Works fine here

[pokey]

great! have a look at the code when you get a minute; it's not nearly as long as the diff implies. the vast majority of the lines of code are in the pnpm lockfile. If you're happy, let's give @auscompgeek a chance to have a look and then let's ship it!

[pokey]

ok @auscompgeek I'm going to go ahead and merge this one in, but feel free to leave comments when you get a minute and I can fix in follow-ups. Biggest remaining annoyance from my perspective is that every test file (eg foo.test.ts) gets bundled into its own output file including all of its dependencies, so locally you end up with a dir of generated files that's about 140MB