Skip to content

Escape json when writing in html #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpkorstanje merged 4 commits into from
Jul 18, 2024
Merged

Escape json when writing in html #312

mpkorstanje merged 4 commits into from
Jul 18, 2024

Conversation

@mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jul 11, 2024 •
edited
Loading

🤔 What's changed?

We're writing the json messages inside a <script> element. This means that the </script> element must be escaped. Or more generally, any /.

⚡️ What's your motivation?

Fixes: #311

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Is there a better way to do this?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the escape-json branch 2 times, most recently from 991bd30 to e9f040a Compare July 11, 2024 19:56
@mpkorstanje
Escape json when writing in html
c6bad2c 
We're writing the json messages inside a `<script>` element. This means
that the `</script>` element must be escaped. Or more generally, any
`/`.
@mpkorstanje mpkorstanje marked this pull request as ready for review July 12, 2024 00:16
@mpkorstanje mpkorstanje merged commit 8bfb97c into main Jul 18, 2024
@mpkorstanje mpkorstanje deleted the escape-json branch July 18, 2024 11:01
@mpkorstanje mpkorstanje mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 18, 2024
Open
Merged
Merged
@bf2robot bf2robot mentioned this pull request May 17, 2024
Open
1 task
@renovate-bot renovate-bot mentioned this pull request Jul 18, 2024
Merged
1 task
This was referenced Jul 18, 2024
Closed
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 18, 2024
Open
Merged
Merged
Merged
@joroelev joroelev mentioned this pull request Jul 19, 2024
Merged
1 task
This was referenced Jul 19, 2024
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Open
Merged
Merged
Closed
This was referenced Dec 19, 2024
Merged
Open
Open
Open
@renovate renovate bot mentioned this pull request Jan 11, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Mar 3, 2025
Closed
1 task
@renovate renovate bot mentioned this pull request May 1, 2025
Merged
1 task
This was referenced Jun 4, 2025
Merged
Open
@renovate renovate bot mentioned this pull request Jun 19, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luke-hill luke-hill Awaiting requested review from luke-hill

@davidjgoss davidjgoss Awaiting requested review from davidjgoss

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Html formatter breaks when step has </script> text

1 participant

@mpkorstanje