Remove Jackson services from META-INF #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like everyone else Cucumber needs to write Json and does so using Jackson. To avoid conflicts with other versions of Jackson, Cucumber shades its own version. Unfortunately this shading isn't done perfectly and the files in `META-INF/services` are not updated to match. By excluding the services declared by Jackson we can avoid this problem altogether, though it may come back in the future if/when Jackson decides to use its own services. Fixes: #2620
mpkorstanje
force-pushed
the
remove-jackson-shaded-services
branch
from
7b44caa to
9fca9bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Like everyone else Cucumber needs to write Json and does so using Jackson. To avoid conflicts with other versions of Jackson, Cucumber shades its own version. Unfortunately this shading isn't done perfectly and the files in
META-INF/servicesare not updated to match.By excluding the services declared by Jackson we can avoid this problem altogether, though it may come back in the future if/when Jackson decides to use its own services outside of
ObjectMapper.findAndRegisterModules. Hopefully, the shade plugin has been fixed by then.Fixes: #2620
🏷️ What kind of change is this?
📋 Checklist: