Cucumber V5 #1449
Merged
Cucumber V5 #1449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Summary
By annotating methods parameter and data table types can be defined as
part of the Glue. This enables them to access the test context and makes
them eligible for dependency injection. Additionally the type registry is
now created for each feature. This means the language of the feature will
be used to convert numbers.
## Details
## Parameter and DataTable Type
Introduces the `@ParameterType` and `@DataTableType` annotations. This
allows parameter and datatable types to be mapped to objects which can
only be created by services inside the test context.
For example in this scenario
```gherkin
Given the awesome catalog
When a user places the awestruck eels in his basket
Then you will be shocked at what happened next
```
We are now able to look up the "awestruck eels" in the "awesome" catalog.
```java
private final Catalog catalog;
@ParameterType(".*")
public Product product(String name) {
return catalog.findProductByName(name);
}
```
## Default Transformer
It is now also possible to register default transformers using
annotations. Default transformers allow you to specific a transformer that
will be used when there is no transform defined. This can be combined with
an object mapper like Jackson to quickly transform well known string
representations to Java objects.
* `@DefaultParameterTransformer`
* `@DefaultDataTableEntryTransformer`
* `@DefaultDataTableCellTransformer`
```java
package com.example.app;
import com.fasterxml.jackson.databind.ObjectMapper;
import io.cucumber.java.DefaultDataTableCellTransformer;
import io.cucumber.java.DefaultDataTableEntryTransformer;
import io.cucumber.java.DefaultParameterTransformer;
import java.lang.reflect.Type;
public class DataTableSteps {
private final ObjectMapper objectMapper = new ObjectMapper();
@DefaultParameterTransformer
@DefaultDataTableEntryTransformer
@DefaultDataTableCellTransformer
public Object defaultTransformer(Object fromValue, Type toValueType) {
return objectMapper.convertValue(fromValue, objectMapper.constructType(toValueType));
}
}
```
## Localization
Some languages uses comma's rather then points to separate decimals.
Previously to parse these properly you'd have to use
`TypeRegistryConfigurer.locale` to set this globally. When not explicitly
provided Cucumber will now take the language from the feature file. This
makes the following work without additional configuration:
```gherkin
# language: fr
Fonctionnalité: Concombres fractionnaires
Scénario: dans la ventre
Étant donné j'ai 5,5 concombres fractionnaires
```
```java
@Étantdonné("j'ai {bigdecimal} concombres fractionnaires")
public void jAiConcombresFractionnaires(BigDecimal arg0) {
assertThat(arg0, is(new BigDecimal("5.5")));
}
```
# Motivation & Context
Fixes #851.
Fixes #1458.
Summary In order to provide different test configurations it might be useful to use different object factories when working with a DI framework. This is described in issue #1690. Details The annotations for JUnit and TestNG now allow to specify the class to instantiate as object factory. A CLI flag has been added to allow the specification of an object factory on the command line (--object-factory). Some minor refactorings along the way. Motivation and Context It is now possible to use different object factories in a Cucumber test suite. Features need to be separated (using tags) and can be grouped as separate tests that are annotated with different CucumberOptions. For each specification of CucumberOptions a different objectFactory can be specified. That way different feature tests can e.g. use differently configured injectors. It is no longer necessary to specify an object factory in cucumber.properties. Object factories are loaded via the ServiceLoader and need to be specified in the file META-INF/services/io.cucumber.core.backend.ObjectFactory. Multiple implementations can be given here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Development branch for v5. Mostly to keep my local artifacts properly versioned.
Closes: #1448
Notable changes so far
cucumber.api.cli.Maininfavour ofio.cucumber.core.api.cli.Main.|io.cucumber.core.backend.BackendProviderio.cucumber.core.backend.ObjectFactoryObjectFactoryTypeRegistryConfigurer.After retiring Cucumber v4
InstantandClockin the event buscucumber.propertiesto https://cucumber.io/docs/cucumber/configuration/@FunctionalInterfacetodatatableandcucumber-expressionsparameters