Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterType transformer runs in World #948

Merged
merged 1 commit into from
Oct 12, 2017
Merged

ParameterType transformer runs in World #948

merged 1 commit into from
Oct 12, 2017

Conversation

aslakhellesoy
Copy link
Contributor

@aslakhellesoy aslakhellesoy commented Oct 11, 2017 •
edited
Loading

Summary

Allow transformer functions to delegate to World

Motivation and Context

Because sometimes we need stuff from the world to transform a string to a "rich" object

How Has This Been Tested?

Unit tests in cucumber-expressions, new scenario in this PR

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

charlierudolph
charlierudolph approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@charlierudolph charlierudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Looks good

@aslakhellesoy aslakhellesoy self-assigned this Oct 12, 2017
@aslakhellesoy aslakhellesoy merged commit a5f085f into master Oct 12, 2017
aslakhellesoy added a commit that referenced this pull request Oct 12, 2017
@aslakhellesoy
Attribution for #948
5245468
@charlierudolph charlierudolph deleted the parameter-type-transform-runs-in-world branch December 8, 2017 17:22
@aslakhellesoy aslakhellesoy mentioned this pull request Sep 12, 2018
Closed
@lock
Copy link

lock bot commented Dec 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlierudolph charlierudolph charlierudolph approved these changes

Assignees

@aslakhellesoy aslakhellesoy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslakhellesoy @charlierudolph