Add BeforeAll / AfterAll hooks #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with BeforeAll and AfterAll. Please do not rename Before to BeforeEach, that would be a big departure from tradition and consistency. |
|
Good stuff! I'm fine with |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbpros
Adding this in preparation for removing registerHandler which I removed in implementing the event protocol. I believe this was why registerHandler was originally exposed. I'll deprecate it in a follow up PR and then make a release.
@aslakhellesoy @mattwynne what do you guys think of BeforeAll/AfterAll? These are test run hooks in contrast to Before/After which are test case hooks. I was also thinking about renaming Before/After to BeforeEach/AfterEach to make the distinction a little more clear. I'd also be good naming these something like BeforeTestRun / BeforeTestCase / AfterTestCase / AfterTestRun