-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple formatters #425
Closed
Closed
multiple formatters #425
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
53ef5df
update
a60de1e
Merge branch 'master' into cr-multipleFormatters
3c41994
update
5d81838
fix
75c6d70
fix scenario description
88b356f
error on invalid path
6ba2982
Merge branch 'master' into cr-multipleFormatters
55351a5
Update multiple_formatters.feature
charlierudolph 53f80c6
Update argument_parser.js
charlierudolph 0e61385
fix unit test
d9ee9f2
update
eb42334
fix test on other platforms
451f452
fix
441e742
fix error code comparison
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
Feature: Multiple Formatter | ||
|
||
Scenario: Ability to specify multiple formatters | ||
Given a file named "features/a.feature" with: | ||
""" | ||
Feature: some feature | ||
|
||
Scenario: I've declared one step which passes | ||
Given This step is passing | ||
""" | ||
And a file named "features/step_definitions/cucumber_steps.js" with: | ||
""" | ||
var cucumberSteps = function() { | ||
this.Given(/^This step is passing$/, function(callback) { callback(); }); | ||
}; | ||
module.exports = cucumberSteps; | ||
""" | ||
When I run cucumber.js with `-f progress -f pretty:pretty.txt` | ||
Then it outputs this text: | ||
""" | ||
. | ||
|
||
1 scenario (1 passed) | ||
1 step (1 passed) | ||
<duration-stat> | ||
""" | ||
And the file "pretty.txt" has the text: | ||
""" | ||
Feature: some feature | ||
|
||
Scenario: I've declared one step which passes # features/a.feature:3 | ||
Given This step is passing # features/a.feature:4 | ||
|
||
1 scenario (1 passed) | ||
1 step (1 passed) | ||
<duration-stat> | ||
""" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing a bad path will currently silently fail. We should listen to errors (
.on('error', ...
) and fail the whole process if something wrong happens.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charlierudolph could you add a test for that case as well? Cucumber's return code should also be non-zero.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbpros added