Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable world proxy in parameter transformers #2465

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Jan 8, 2025

🤔 What's changed?

Calls to getInvocationParameters (where we call the transformer function on a custom parameter) are now wrapped in test case scope which enables use of the world proxy. This matches the existing behaviour where the world instance is passed as this to the transformer.

⚡️ What's your motivation?

Fixes #2447.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Jan 8, 2025

Coverage Status

coverage: 97.733% (+0.001%) from 97.732%
when pulling bca9b57 on world-proxy-parameter-types
into f0ef001 on main.

@davidjgoss davidjgoss marked this pull request as ready for review January 8, 2025 23:34
@davidjgoss davidjgoss merged commit 18988fd into main Jan 8, 2025
10 checks passed
@davidjgoss davidjgoss deleted the world-proxy-parameter-types branch January 8, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The imported world-Proxy should also work in the transformer method for defineParameterType
2 participants