Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse AfterAll execution order #2456

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Reverse AfterAll execution order #2456

merged 4 commits into from
Dec 11, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Dec 11, 2024

🤔 What's changed?

Reverse the AfterAll hooks array before executing them in the new worker.

⚡️ What's your motivation?

Fixes #2455.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title Fix AfterAll execution order Reverse AfterAll execution order Dec 11, 2024
@coveralls
Copy link

coveralls commented Dec 11, 2024

Coverage Status

coverage: 97.688%. remained the same
when pulling fab5961 on fix/afterall-order-fix
into f0122a3 on main.

@davidjgoss davidjgoss marked this pull request as ready for review December 11, 2024 20:41
@davidjgoss davidjgoss merged commit b4cf626 into main Dec 11, 2024
10 checks passed
@davidjgoss davidjgoss deleted the fix/afterall-order-fix branch December 11, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After() hooks execution order with Cucumber 11.0.1
2 participants