Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JUnit formatter with messages-based package #2445

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Nov 15, 2024

🤔 What's changed?

This PR replaces the existing JUnit formatter - built using the old-style pattern - with the one from https://github.com/cucumber/junit-xml-formatter.

⚡️ What's your motivation?

The new formatter has parity with the Java implementation and uses the new plugin-based pattern with messages and query.

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

(This is not a breaking change because the old formatter was never publicly exported.)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss changed the title replace junit formatter with messages-based package Replace junit formatter with messages-based package Nov 15, 2024
@coveralls
Copy link

coveralls commented Nov 15, 2024

Coverage Status

coverage: 97.765% (-0.07%) from 97.838%
when pulling 0cc5c7b on junit-formatter-messages
into ddf424a on main.

@davidjgoss davidjgoss changed the title Replace junit formatter with messages-based package Replace JUnit formatter with messages-based package Nov 16, 2024
@davidjgoss davidjgoss marked this pull request as ready for review November 16, 2024 10:43
@davidjgoss davidjgoss merged commit 03a57a5 into main Nov 16, 2024
8 checks passed
@davidjgoss davidjgoss deleted the junit-formatter-messages branch November 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants