Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle UNKNOWN status when rendering test run outcome #2441

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

hynding
Copy link
Contributor

@hynding hynding commented Nov 5, 2024

🤔 What's changed?

Updated CLI status message list to include Unknown case

⚡️ What's your motivation?

Fixes #2440

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Pretty new to committing to a large public project so anything that comes to mind, including branch and PR naming convention, unit test coverage and if I should update the CHANGELOG Unreleased section(?).

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
    • I have added/updated tests to cover my changes.
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@coveralls
Copy link

coveralls commented Nov 5, 2024

Coverage Status

coverage: 97.688%. remained the same
when pulling bd49dea on hynding:fix-2440-cli-unknown-scenario
into 1c4d9c5 on cucumber:main.

@hynding hynding changed the title fix: updated cli message list and related unit test for scenario messaging (2440) Updated cli message list and related unit test for scenario messaging; fixes issue #2440 Nov 5, 2024
@hynding hynding changed the title Updated cli message list and related unit test for scenario messaging; fixes issue #2440 Updated cli message list and related unit test for scenario messaging Nov 5, 2024
@davidjgoss davidjgoss changed the title Updated cli message list and related unit test for scenario messaging Handle UNKNOWN status when rendering test run outcome Nov 16, 2024
Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@davidjgoss davidjgoss merged commit ee538bd into cucumber:main Nov 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving "NaN scenarios" in CLI when there is an unlabeled "Scenario:" in a feature file
3 participants