Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honour order of paths in configuration #2345

Merged
merged 3 commits into from
Oct 20, 2023
Merged

honour order of paths in configuration #2345

merged 3 commits into from
Oct 20, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Oct 20, 2023

🤔 What's changed?

Change where we sort the list of expanded paths - do it for the results of each unexpanded path rather than once at the end for the whole result set, meaning the order of paths in the configuration is honoured.

⚡️ What's your motivation?

Fixes #2343.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Oct 20, 2023

Coverage Status

coverage: 97.833% (-0.001%) from 97.834% when pulling d6564d0 on fix/2343 into 52fa813 on main.

@davidjgoss davidjgoss marked this pull request as ready for review October 20, 2023 21:30
@davidjgoss davidjgoss merged commit f98d567 into main Oct 20, 2023
6 checks passed
@davidjgoss davidjgoss deleted the fix/2343 branch October 20, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cucumber 10.0.0 changes execution order of the feature files when paths configuration is provided
2 participants