Use of const keyword

[gjcampbell]

Use of the const keyword as in the following does not work in IE. The demo page does not work in IE because of this. Couldn't the browser version of this have use of const replaced with var?

const _lexer_actions = [ ...

[jbpros]

Thank you @Sledgebox. It's a Gherkin issue. It's been reported.

[jbpros]

Fixed on Gherkin. We need a Gherkin release now :)

[jbpros]

Gherkin 2.11.3 breaks cucumber.js. Investigating.

[aslakhellesoy]

That's not good. node_modules/.bin/jasmine-node spec works with both 2.11.1 and 2.11.3 for me. How does it break?

[aslakhellesoy]

Ok, ./bin/cucumber.js breaks...

[aslakhellesoy]

To reproduce in gherkin proper: node js/example/print.js

[jbpros]

@aslakhellesoy Looks like https://github.com/cucumber/gherkin/blob/master/js/lib/gherkin.js#L5 is not correct anymore. Lexer modules do not export any Lexer property anymore (which is better IMO). This is quite an old change already.

Another problem is that the listener object passed to gherkin is explicitely checked for the presence of all event handlers, including scenario_outline and example. Cucumber.js is currently not exposing those two.

I'm fixing the latter and I worked around the former by directly requiring gherkin/lib/gherkin/lexer/en but a fix in Gherkin is needed. Do you want me to make an issue for it? Pull request sent.

[jbpros]

@aslakhellesoy BTW, when you want to run cucumber.js's tests, please invoke $ rake to run the feature suite (through cucumber-ruby and cucumber-js) in addition to the specs. The specs were not supposed to fail here as Gherkin's API is mocked, but the feature suite was expected to go red and it did.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.