Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string definition pattern #77

Closed
sullerandras opened this issue Jul 19, 2012 · 3 comments
Closed

string definition pattern #77

sullerandras opened this issue Jul 19, 2012 · 3 comments

Comments

@sullerandras
Copy link

In the readme:

'I have $count "$string"' would translate to /^I have (.*) "([^"]*)")$/.

This is not true. It will be translated to /I have (.*) "([^"]*)")/, without the ^ and $ signs. Can you update the readme, or fix this issue in the source?

@jbpros
Copy link
Member

jbpros commented Jul 19, 2012

Nice catch, thank you for reporting this. The README is correct, the code is not. We'll fix that.

@jbpros
Copy link
Member

jbpros commented Jul 19, 2012

In addition to this problem, the original string is not properly escaped:

Given('I have $count1 + $count2 "$string"')

will translate to

/I have (.*) + (.*) "([^"]*)")/

instead of the expected

/I have (.*) \+ (.*) "([^"]*)")/.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants