Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags support #7

Closed
jbpros opened this issue Jun 1, 2011 · 8 comments
Closed

Tags support #7

jbpros opened this issue Jun 1, 2011 · 8 comments
Assignees
@jbpros
Milestone
0.3 critical feat...

Comments

@jbpros
Copy link
Member

jbpros commented Jun 1, 2011

Add support for tags on features and scenario; filter based on those tags.

https://github.com/cucumber/cucumber/wiki/Tags
@ghost ghost assigned jbpros Jan 20, 2012
@jbpros
Copy link
Member Author

jbpros commented Jan 20, 2012

This is the next addition. Waiting for tags.feature to be reviewed.

@mcollina
Copy link
Contributor

+1, with this added it will be ready for my daily usage.

@jbpros
Copy link
Member Author

jbpros commented Jan 27, 2012

@mcollina It's on its way :)

jbpros added a commit that referenced this issue Jan 29, 2012
@jbpros
Refactor parser and add AST assembler (required by #7)
2c5283d 
In order to get tag support (#7), it was necessary to decouple Gherkin parsing callbacks from the actual assembly of the Abstract Structured Tree.

- Extracted AST assembly logic into a new Cucumber.Ast.Assembler object;
- AST elements now handle specific back-references instead of relying on the builder (e.g. previously, the parser was setting the background on a new scenario; the Feature element is now taking care of it when the scenario is appended);
- Refactored some related specs.
jbpros added a commit that referenced this issue Jan 29, 2012
@jbpros
Refactor AST assembler to be stateful (needed by #7)
4a09f36
@jbpros jbpros mentioned this issue Feb 3, 2012
Closed
@jbpros jbpros closed this as completed in c5dcf07 Feb 3, 2012
@jbpros jbpros reopened this Feb 3, 2012
@jbpros
Copy link
Member Author

jbpros commented Feb 3, 2012

Tags on scenarios are supported but not on features yet.

@jbpros jbpros closed this as completed in 01cfa8c Feb 3, 2012
@mcollina
Copy link
Contributor

mcollina commented Feb 3, 2012

Nice!!

@jbpros
Copy link
Member Author

jbpros commented Feb 3, 2012

@mcollina I'll release this tomorrow.

@jbpros
Copy link
Member Author

jbpros commented Feb 4, 2012

Tags are now live on 0.2.6!

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbpros jbpros

Labels
None yet
Projects
None yet
Milestone
0.3 critical features
Development

No branches or pull requests
2 participants
@mcollina @jbpros