-
-
Notifications
You must be signed in to change notification settings - Fork 60
Remove support for Python 3.7 and extend support to 3.12 #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5f3a0c9
to
f100030
Compare
f100030
to
65d71f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to merge after applying the suggestion to the changelog.
Python 3.7 was not being tested in the pipeline, is unsupported by our version of Poetry and has reached End of Life. Have removed support, let me know if any feedback on that decision.
Usually, we only do the latest two stable releases. This avoids a plethora of CI jobs (and the potential headaches that come with having to support many versions). But supporting more versions is fine. As long as they're not EOL.
If the activated Python version in the test job is below the required version of the package, poetry falls back on other installed versions (in this case 3.10). This presents a risk as the pipeline will pass if the required Python version is bumped and not failing for older Python versions still in the pipeline.
I'm not sure I follow this. The matrix job should install only a single version of python. How can it fall back to a version that wasn't installed by the job?
Co-authored-by: M.P. Korstanje <[email protected]>
The Poetry was set to 3.10 upwards: [tool.poetry.dependencies]
python = "^3.10" And the test job was configured for Python 3.8-3.10. python-version: ["3.8", "3.9", "3.10"] However, rather than fail with 3.8 and 3.9, poetry looks for a compatible Python version, finding 3.10 of The currently activated Python version 3.8.18 is not supported by the project (^3.10).
Trying to find and use a compatible version.
Using python3.10 (3.10.12) |
Thanks for explaining! Very clear. |
🤔 What's changed?
Reverted required Python versions from 3.10+ back to 3.8+. Removed Python 3.7.
Added pipeline testing against Python 3.11 and 3.12.
⚡️ What's your motivation?
Support officially supported Python distributions, re-enabling 3.8 and 3.9; to support users appropriately.
Fixes that test jobs with 3.8 and 3.9 were incorrectly running 3.10.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Python 3.7 was not being tested in the pipeline, is unsupported by our version of Poetry and has reached End of Life. Have removed support, let me know if any feedback on that decision.
If the activated Python version in the test job is below the required version of the package, poetry falls back on other installed versions (in this case 3.10). This presents a risk as the pipeline will pass if the required Python version is bumped and not failing for older Python versions still in the pipeline.
📋 Checklist: