Skip to content

Fixes for issue #51 visible on some systems. #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paoloambrosio merged 2 commits into from
Dec 3, 2012
Merged

Fixes for issue #51 visible on some systems. #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75419d1
Fixes for issue #51 visible on some systems.
Sabst Dec 3, 2012
201f842
Merge pull request #1 from Sabst/issue#51
Sabst Dec 3, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/cucumber-cpp/internal/connectors/wire/WireProtocol.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class StepMatchesResponse : public WireResponse {

public:
StepMatchesResponse(const std::vector<StepMatch> & matchingSteps);
const std::vector<StepMatch> getMatchingSteps() const;
const std::vector<StepMatch>& getMatchingSteps() const;

void accept(WireResponseVisitor *visitor) const;
};
Expand Down
2 changes: 1 addition & 1 deletion include/cucumber-cpp/internal/step/StepManager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class MatchResult {
public:
typedef std::vector<SingleStepMatch> match_results_type;

const match_results_type getResultSet();
const match_results_type& getResultSet();
void addMatch(SingleStepMatch match);

operator void *();
Expand Down
2 changes: 1 addition & 1 deletion src/StepManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ MatchResult::operator bool() {
return !resultSet.empty();
}

const MatchResult::match_results_type MatchResult::getResultSet() {
const MatchResult::match_results_type& MatchResult::getResultSet() {
return resultSet;
}

Expand Down
2 changes: 1 addition & 1 deletion src/connectors/wire/WireProtocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ StepMatchesResponse::StepMatchesResponse(const std::vector<StepMatch> & matching
: matchingSteps(matchingSteps) {
}

const std::vector<StepMatch> StepMatchesResponse::getMatchingSteps() const {
const std::vector<StepMatch>& StepMatchesResponse::getMatchingSteps() const {
return matchingSteps;
}

Expand Down