Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky QtTestDriver test #296

Merged
merged 1 commit into from
May 9, 2024

Conversation

ursfassler
Copy link
Contributor

@ursfassler ursfassler commented Apr 29, 2024

Summary

The test output contained timing information, leading to a flaky test. Fixed by using the TAP output, that doesn't contain timing information.

Details

See https://doc.qt.io/qt-6/qtest-overview.html#logging-options for more information.

Motivation and Context

Solves the issue from this PR: #293 (comment)

How Has This Been Tested?

The fix itself is only manually verified. The code has automated tests, hence pretty sure to not have added a regression.

Note: the log output changed, but it should only affect developers reading the log.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • It is my own work, its copyright is implicitly assigned to the project and no substantial part of it has been copied from other sources (including Stack Overflow). In rare occasions this is acceptable, like in CMake modules where the original copyright information should be kept.
  • I'm using the same code standards as the existing code (indentation, spacing, variable naming, ...).
  • I've added tests for my code.
  • I have verified whether my change requires changes to the documentation
  • My change either requires no documentation change or I've updated the documentation accordingly.
  • My branch has been rebased to main, keeping only relevant commits.

The test output contained timing information, leading to a flaky test.
Fixed by using the TAP output, that doesn't contain timing information.
@ursfassler ursfassler marked this pull request as ready for review April 29, 2024 12:20
@ursfassler
Copy link
Contributor Author

@kreuzberger please have a look. Would be happy to get feedback if this fixes the flaky tests you encountered.

@ursfassler ursfassler mentioned this pull request Apr 29, 2024
9 tasks
@kreuzberger
Copy link
Contributor

@kreuzberger please have a look. Would be happy to get feedback if this fixes the flaky tests you encountered.

as the tap format does not contain timing informations, yes this would fix it.
👍

@ursfassler ursfassler merged commit e1fa84f into cucumber:main May 9, 2024
9 checks passed
@ursfassler ursfassler deleted the fix-flaky-qttestdriver-test branch May 9, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants